Skip to content

feat(python/flyte-deploy)!: take the client credentials as inputs instead of vault - #252

Merged
dan-n94 merged 1 commit into
mainfrom
feat/flyte-deploy-secret-inputs
Nov 16, 2026
Merged

dan-n94 merged 1 commit into
mainfrom
feat/flyte-deploy-secret-inputs

Conversation

@dan-n94

@dan-n94 dan-n94 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Removes the last Vault read from ci-actions. python/flyte-deploy takes the deploy client credentials as inputs, like docker/build-push v1.0.0 and python/publish v2.0.0.

  • New inputs: client-id (required), client-secret (required), client-scope (optional, empty = what the endpoint advertises).
  • Removed: vault-url, vault-role, vault-secret-clientid, vault-secret-clientsecret, vault-secret-clientscope, and the hashicorp/vault-action step.
  • Callers no longer need permissions: id-token: write.

Breaking: release-please will cut python/flyte-deploy v2.0.0.

Before merging

The org secrets don't exist yet. Add them to the External Secrets sync in k8s-deploy/infra/github-secrets (Vault k8s/flyte/oauth: deployClientId, deployClientSecret, deployClientScope):

  • FLYTE_DEPLOY_CLIENT_ID
  • FLYTE_DEPLOY_CLIENT_SECRET
  • FLYTE_DEPLOY_CLIENT_SCOPE

Callers to migrate after release

GrainWise.segmentation, lab-microscope-flows, preimage, industrial-eagler. Each pins a v1 tag or sha, so nothing breaks until they bump.

…tead of vault

The deploy client id, secret and scope come from the new `client-id`,
`client-secret` and `client-scope` inputs instead of Vault. Callers no longer
need `id-token: write`.

BREAKING CHANGE: `client-id` and `client-secret` are now required and the
`vault-*` inputs are removed. Pass them from the org secrets:

    client-id: ${{ secrets.FLYTE_DEPLOY_CLIENT_ID }}
    client-secret: ${{ secrets.FLYTE_DEPLOY_CLIENT_SECRET }}
    client-scope: ${{ secrets.FLYTE_DEPLOY_CLIENT_SCOPE }}
@dan-n94
dan-n94 force-pushed the feat/flyte-deploy-secret-inputs branch from cfc4a07 to 7fe7a3a Compare November 16, 2026 10:21
@dan-n94
dan-n94 requested a review from antholzer November 16, 2026 10:23
@dan-n94

dan-n94 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

@dan-n94
dan-n94 merged commit 0ad94a4 into main Nov 16, 2026
1 check passed
@dan-n94
dan-n94 deleted the feat/flyte-deploy-secret-inputs branch November 16, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants