Repository navigation
feat(python/flyte-deploy)!: take the client credentials as inputs instead of vault - #252
Merged
Merged
Conversation
…tead of vault
The deploy client id, secret and scope come from the new `client-id`,
`client-secret` and `client-scope` inputs instead of Vault. Callers no longer
need `id-token: write`.
BREAKING CHANGE: `client-id` and `client-secret` are now required and the
`vault-*` inputs are removed. Pass them from the org secrets:
client-id: ${{ secrets.FLYTE_DEPLOY_CLIENT_ID }}
client-secret: ${{ secrets.FLYTE_DEPLOY_CLIENT_SECRET }}
client-scope: ${{ secrets.FLYTE_DEPLOY_CLIENT_SCOPE }}
dan-n94
force-pushed
the
feat/flyte-deploy-secret-inputs
branch
from
November 16, 2026 10:21
cfc4a07 to
7fe7a3a
Compare
Contributor
Author
antholzer
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last Vault read from ci-actions.
python/flyte-deploytakes the deploy client credentials as inputs, likedocker/build-pushv1.0.0 andpython/publishv2.0.0.client-id(required),client-secret(required),client-scope(optional, empty = what the endpoint advertises).vault-url,vault-role,vault-secret-clientid,vault-secret-clientsecret,vault-secret-clientscope, and thehashicorp/vault-actionstep.permissions: id-token: write.Breaking: release-please will cut
python/flyte-deployv2.0.0.Before merging
The org secrets don't exist yet. Add them to the External Secrets sync in
k8s-deploy/infra/github-secrets(Vaultk8s/flyte/oauth:deployClientId,deployClientSecret,deployClientScope):FLYTE_DEPLOY_CLIENT_IDFLYTE_DEPLOY_CLIENT_SECRETFLYTE_DEPLOY_CLIENT_SCOPECallers to migrate after release
GrainWise.segmentation,lab-microscope-flows,preimage,industrial-eagler. Each pins a v1 tag or sha, so nothing breaks until they bump.